Set explicit beans.xml scanning mode #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-confino
force-pushed
the
cdi4
branch
4 times, most recently
from
2b6ed3a
to
cdaa5cc
Compare
…e is now treated as scanning mode annotated instead of mode all Setting an explicit scanning mode will make behaviour consistant across all versions of CDI.
benjamin-confino
force-pushed
the
cdi4
branch
from
cdaa5cc
to
66eacdf
Compare
|
Speaking to Andrew we will not be delivering this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an explicit scanning mode will make behaviour consistent across all versions of CDI.
Short description of what this resolves: The CDI 4.0 spec introduces a breaking change: An empty beans.xml fie is now treated as scanning mode annotated instead of mode all. This causes a problem because this plugin needs scanning mode all.
Changes proposed in this pull request: Replace every empty beans.xml file with one that explicitly declares a scanning mode of all
Fixes: # 134 (though other fixes may be required to fully resolve the issue)