Discussion: Remove app/design/frontend/default/iphone and app/design/frontend/default/modern

[kkrieger85]

Both resources are not up to date.

Google expects (and ranks higher) RWD design.

Also, there is a RWD Design/Approach in default designs.

Proposal: Extract each to mandatory theme-module

[kkrieger85]

Pro: It would make code-review easier (less files)

[luigifab]

Perhaps we can also remove app/design/frontend/default (with all subdirectories) and move skin/frontend/default subdirectories to skin/frontend/base (and we can remove some of them) ? 👼

[colinmollenhour]

If they are broken I say remove them...

[dng-dev]

I agree totally on that Colin Mollenhour <notifications@github.com> schrieb am Sa. 13. Juni 2020 um 01:24:

…

If they are broken I say remove them... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1037 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMD36I2M6E5ED4WMT3EWDRWK2LBANCNFSM4N4DAJ7Q> .

-- Valmano GmbH • Schwedter Straße 263 • 10119 Berlin Geschäftsführer: Michael Berghoff, Stefanie Köttendorf Registergericht: Berlin-Charlottenburg, HRB 150237 B This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not the intended recipient,you must not copy this message or attachment or disclose the contents to any other person. If you have received this transmission in error, please notify the sender immediately and delete the message and any attachment from your system.

[Flyingmana]

People may still rely on them in one way or another.
Even if we do changes in this area, we should do this as part of one of the later releases.

Besides that, fully support the removal of them.

[colinmollenhour]

@Flyingmana What about starting a "next-major-release" (or more typically "dev") branch so we can start merging things for the next major release?

[kkrieger85]

So
Step 1: Add deprecation warning for default/iphone and default/modern in current release

Step 2: Move both themes in external theme modules, installable with composer

[fballiano]

I think that who uses those themes is not on the latest version or didn't install via composer, so they shouldn't be harmed but a removal from the default package.

Probably the "next-major-release" approach suggested by @colinmollenhour is the safest.

IMHO I'd love to see those directories out of this repo.

[fballiano]

Working on #1599 I took some time to check the "default" themes (default/default, modern, iphone, blue). They're outdated, ugly, unmaintained and, let's face it, nobody (that may ever update) uses them.

They should be removed from 20.x and we should only keep base and rwd.

They could be kept in a separate repo but... really? It is not worth it, nobody will ever open an issue about those.

[tmotyl]

I agree with @fballiano even years ago they were already outdated/not useful

[pauldpauld]

As an admin of only two websites, having used Magento since 1.4.1.1 I never used them either.
Agreed; outdated/not useful.

[kkrieger85]

Merged to 20.x upstream in #1600