Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added VAT related attributes to salesOrderAddressEntity webservices entity #3885

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

empiricompany
Copy link
Contributor

@empiricompany empiricompany commented Mar 19, 2024

Description (*)

Add this fields in webservice at salesOrderAddressEntity
vat_id, vat_is_valid, vat_request_id, vat_request_date, vat_request_success

Related Pull Requests

Manual testing scenarios (*)

  1. Set vat_frontend_visibility = true in Customer Configuration to collect vat_id in address entity
    vat_frontend_visibility
  2. Create a new order and fill vat
  3. Test webservice salesOrderInfo, in billing_address object you must have all details of vat
[billing_address] => stdClass Object
(
    [parent_id] => 210
    [address_type] => billing
    [firstname] => Test
    [lastname] => test
    [company] => company
    [vat_id] => 00000000000
    [vat_is_valid] => 1
    [vat_request_id] => xxx
    [vat_request_date] => 2024-03-18+01:00
    [vat_request_success] => 1
    ...
    [address_id] => 410
)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Mar 19, 2024
@empiricompany empiricompany changed the title expose vat info in webservices Expose vat info in webservices Mar 19, 2024
@fballiano fballiano changed the title Expose vat info in webservices Added VAT related attributes to salesOrderAddressEntity webservices entity Mar 20, 2024
@fballiano fballiano merged commit d2039c8 into OpenMage:main Mar 24, 2024
14 checks passed
empiricompany added a commit to empiricompany/devdocs-m1 that referenced this pull request Jun 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants