Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updated PHPStan to 1.11.2 #3988

Merged
merged 14 commits into from
May 29, 2024
Merged

Updated PHPStan to 1.11.2 #3988

merged 14 commits into from
May 29, 2024

Conversation

fballiano
Copy link
Contributor

@fballiano fballiano commented May 13, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Adminhtml Relates to Mage_Adminhtml Component: CatalogIndex Relates to Mage_CatalogIndex Component: lib/* Relates to lib/* composer Relates to composer.json PHPStorm labels May 13, 2024
@fballiano fballiano changed the title Updated PHPStan to 1.11.0 Updated PHPStan to 1.11.1 May 15, 2024
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle labels May 16, 2024
This was referenced May 20, 2024
Closed
Closed
@fballiano fballiano changed the title Updated PHPStan to 1.11.1 Updated PHPStan to 1.11.2 May 27, 2024
@fballiano
Copy link
Contributor Author

@Flyingmana @Sdfendor @kiatng could you take a look at this?

@fballiano
Copy link
Contributor Author

I've retested this (mostly where the parent::construct() was removed, becuase the parent contructor is empty), just to be safe, can't see any problem.

I'll merge it.

@fballiano fballiano merged commit 26fe971 into OpenMage:main May 29, 2024
18 checks passed
@fballiano fballiano deleted the phpstan11 branch May 29, 2024 14:35
@F1Red5
Copy link
Contributor

F1Red5 commented May 29, 2024

@fballiano we have a modified abstract class Mage_Catalog_Model_Product_Type_Abstract with some custom code in save() method. With the removal of parent::construct() it does not work anymore. Can you please revert it?

@fballiano
Copy link
Contributor Author

@F1Red5 could you override also the child class? I've removed it because phpstan complained that it's useless

@fballiano fballiano mentioned this pull request May 29, 2024
Merged
@fballiano
Copy link
Contributor Author

@F1Red5 check #4021 and if it solves (I think it's correct to restore the previous behavior) please vote for it.

fballiano added a commit that referenced this pull request May 30, 2024
@fballiano
Restored parent::save() on a few classes (fixing PHPStan) ref #3988 (#…
ed34c76 
…4021)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@boesbo boesbo boesbo approved these changes

@kiatng kiatng Awaiting requested review from kiatng

@elidrissidev elidrissidev Awaiting requested review from elidrissidev

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: Core Relates to Mage_Core Component: Downloadable Relates to Mage_Downloadable Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales composer Relates to composer.json PHPStorm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fballiano @F1Red5 @boesbo