Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update for phpstan 1.12.3 #4206

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update for phpstan 1.12.3 #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401908d
phpstan fix
sreichel Sep 18, 2024
4e7428e
updated composer.lock
sreichel Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4860,11 +4860,6 @@ parameters:
count: 1
path: lib/Mage/DB/Mysqli.php

-
message: "#^Property Mage_HTTP_Client_Curl\\:\\:\\$_ch \\(object\\) does not accept resource\\.$#"
count: 1
path: lib/Mage/HTTP/Client/Curl.php

-
message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_postFields is never read, only written\\.$#"
count: 1
Expand Down
4 changes: 0 additions & 4 deletions .phpstan.dist.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,5 @@ parameters:
checkFunctionNameCase: true
checkInternalClassCaseSensitivity: true
treatPhpDocTypesAsCertain: false
# For v1.12+ with "bleeding edge"
ignoreErrors:
-
identifier: missingType.iterableValue
# universalObjectCratesClasses:
# - Varien_Object
10 changes: 5 additions & 5 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/Mage/HTTP/Client/Curl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class Mage_HTTP_Client_Curl implements Mage_HTTP_IClient

/**
* Curl
* @var object
* @var false|resource
*/
protected $_ch;

Expand Down