Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rector: added dependency and basic rules #4213

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 19, 2024

Description (*)

  • added rector as composer dependeny
  • added rules to config (all these rules have already been used ... nothing new here at all)
  • fixed a few lines (maybe new, or newly dedected)
  • added rector to workflow
  • added ddev & composer shortcuts

ddev:

ddev rector --dry-run
ddev rector

composer:

composer run rector:test
composer run rector:fix

... add a path to this commands to test your own extensions code.

Happy coding :)

@github-actions github-actions bot added environment composer Relates to composer.json ddev labels Sep 19, 2024
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: GoogleAnalytics Relates to Mage_GoogleAnalytics labels Sep 19, 2024
@kiatng kiatng merged commit 75cd467 into OpenMage:main Sep 22, 2024
21 checks passed
@sreichel sreichel deleted the rector-base branch September 22, 2024 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: GoogleAnalytics Relates to Mage_GoogleAnalytics composer Relates to composer.json ddev environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants