-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Better sitemap configuration #4308
Open
sreichel
wants to merge
7
commits into
OpenMage:main
Choose a base branch
from
sreichel:sitemap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Catalog
Relates to Mage_Catalog
Component: Cms
Relates to Mage_Cms
Component: Sitemap
Relates to Mage_Sitemap
phpstan
labels
Oct 25, 2024
I cannot see how some changes are related to sitemap. It'll be nice to have separate PRs for those. |
What should i roll back? Its only some added tests and 2-3 changes to getStoreConfligFlag. And some typos. |
# Conflicts: # .phpstan.dist.baseline.neon # app/code/core/Mage/Catalog/Model/Product.php # tests/unit/Mage/Sitemap/Model/SitemapTest.php
Merged
Moved some changes to #4321. Lets merge it first. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Component: Catalog
Relates to Mage_Catalog
Component: Cms
Relates to Mage_Cms
Component: Sitemap
Relates to Mage_Sitemap
enhancement
phpstan
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added option to not add products/categories/csm-pages to xml sitemap. Fixed a bug in admin/system/config where options depend on wrong field.
Related Pull Requests
Manual testing scenarios (*)