Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix error in column renderer when value is empty and not null #4601

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix error in column renderer when value is empty and not null #4601

merged 3 commits into from
Feb 20, 2025
+1 −1

Conversation

aamant
Copy link
Contributor

@aamant aamant commented Feb 5, 2025

Description (*)

fix class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number when value is empty

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 5, 2025
@sreichel
Copy link
Contributor

sreichel commented Feb 5, 2025

Thanks. Whats the error message?

Can you provide steps to reproduce?

@aamant
Copy link
Contributor Author

aamant commented Feb 5, 2025

This error occurs when the expected value is empty but not null

Capture d’écran 2025-02-05 à 10 05 15

@sreichel
Copy link
Contributor

sreichel commented Feb 5, 2025

This error occurs

Please add error message and stacktrace.

@aamant
Copy link
Contributor Author

aamant commented Feb 5, 2025

Capture d’écran 2025-02-05 à 12 11 36

colinmollenhour
colinmollenhour requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of empty('0') is true, so this would change the behavior such that '0' renders the default value rather than '0'.

@aamant
Copy link
Contributor Author

aamant commented Feb 13, 2025

I've updated the test

kiatng
kiatng approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test: https://onlinephp.io/c/38a62

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kiatng kiatng changed the title fix error in column renderer when valud is empty and not null Fix error in column renderer when value is empty and not null Feb 20, 2025
@kiatng kiatng merged commit b7f2386 into OpenMage:main Feb 20, 2025
18 of 19 checks passed
@sreichel sreichel added the bug label Feb 20, 2025
@aamant aamant mentioned this pull request Feb 21, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
bug Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aamant @sreichel @colinmollenhour @kiatng