Skip to content

Commit

Permalink
replace ftop with fl_client
Browse files Browse the repository at this point in the history
  • Loading branch information
khoaguin committed Nov 18, 2024
1 parent 4969b61 commit db0e4a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dashboard/syftbox-sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@
});

if (response.status === 200) {
this.show("ftop", version, source, iconUrl);
this.show("fl_client", version, source, iconUrl);
} else {
throw new Error("Installation failed");

This comment has been minimized.

Copy link
@dembygenesis

dembygenesis Nov 18, 2024

We might not need the else statement here, and just fail if 200 isn't the response.status

This comment has been minimized.

Copy link
@khoaguin

khoaguin Nov 22, 2024

Author Member

thanks @dembygenesis
but is it better if we have a more specific Error message (e.g." Installation failed")?

}
Expand Down

0 comments on commit db0e4a5

Please # to comment.