Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for multiple files #24

Merged
merged 8 commits into from
May 29, 2024

Conversation

ehedbor
Copy link
Contributor

@ehedbor ehedbor commented May 22, 2024

No description provided.

@AnHeuermann AnHeuermann linked an issue May 22, 2024 that may be closed by this pull request
@ehedbor ehedbor marked this pull request as ready for review May 23, 2024 12:49
@ehedbor
Copy link
Contributor Author

ehedbor commented May 23, 2024

This branch was based off the prettier branch and was created before the PR (#23) was accepted. It seems that Git thinks the prettier commits in main are different from the ones in this branch, so its counting all the changes twice. Now Git is asking me to resolve changes that are supposed to be in the past and I'm not entirely sure how to fix this. We definitely did not change 30 files in this pull request!

PaddiM8 and others added 5 commits May 23, 2024 15:41
@PaddiM8
Copy link
Contributor

PaddiM8 commented May 23, 2024

I rebased it to change the parent commit. Seems to have worked.

@PaddiM8
Copy link
Contributor

PaddiM8 commented May 23, 2024

@AnHeuermann

@AnHeuermann
Copy link
Member

The end to end test is failing for me (and the CI). When calling getDeclarationsForUri for client/testFixture/MyLibrary.mo the tree is not yet created. I guess in addition to automatically exploring files from the workspace directory you need to analyze opened files from outside the workspace directory. Maybe an additional call to addDocument is needed?

@PaddiM8
Copy link
Contributor

PaddiM8 commented May 24, 2024

Yeah that was the problem indeed. It should now add documents that don't belong to a library in the workspace.

@PaddiM8
Copy link
Contributor

PaddiM8 commented May 28, 2024

Could you re-run the tests?

  - Added it to ticket on GitHub
@AnHeuermann
Copy link
Member

I forgot to enable the contributor license agreement for this repository. I enabled it just now, and it tells that everybody did sign the CLA. @ehedbor and @PaddiM8 can you confirm or is it just broken?

@AnHeuermann
Copy link
Member

Did a quick double check and everybody signed the CLA. Perfect.

@AnHeuermann AnHeuermann merged commit 5cb52b8 into OpenModelica:main May 29, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

How to handle multiple Modelica files
3 participants