Add incremental parsing support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: this was fixed |
PaddiM8
force-pushed
the
incremental-parsing
branch
from
fcaf1aa
to
14695bd
Compare
PaddiM8
force-pushed
the
incremental-parsing
branch
2 times, most recently
from
7f32dbe
to
7d8b395
Compare
|
@AnHeuermann this PR is ready for review now 👍 |
PaddiM8
force-pushed
the
incremental-parsing
branch
from
7d8b395
to
ab55fb2
Compare
PaddiM8
force-pushed
the
incremental-parsing
branch
from
ab55fb2
to
bfe7c14
Compare
Closed
AnHeuermann
approved these changes
May 29, 2024
| } | ||
| ); | ||
|
|
||
| assert.equal(document.getText().trim(), UPDATED_TEST_PACKAGE_CONTENT.trim()); |
There was a problem hiding this comment.
Add an additional assert to test that the tree indeed is updated. In this case it's hard to tell, so maybe do an update that does change the tree. Maybe adding another annotation or model or so.
Otherwise we aren't sure that the tree was updated.
There was a problem hiding this comment.
Ups, wrong button. I wanted to request changes on my review^^. Please check if you can update the test.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.