Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to cibuildwheel and build macOS wheels #213

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

keichi
Copy link
Contributor

@keichi keichi commented Dec 27, 2020

Closes #42

This PR is largely based on @filips123's efforts at #136, integrated with the current GitHub Actions CI script.

Note that I had to move the extension to a subpackage (pyonmttok._ext) due to a limitation in the delocate utility (see https://github.com/matthew-brett/delocate#external-library-is-not-bundled-into-wheel and matthew-brett/delocate#72).

Copy link
Collaborator

@guillaumekln guillaumekln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! The changes are looking good.

@keichi
Copy link
Contributor Author

keichi commented Dec 28, 2020

Thanks for the review, I've addressed your comments.

@guillaumekln
Copy link
Collaborator

Thanks!

@guillaumekln guillaumekln merged commit 9473db8 into OpenNMT:master Dec 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install pyonmttok on macOS?
2 participants