Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docs #3114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docs #3114

wants to merge 2 commits into from

Conversation

aleixrm
Copy link
Member

@aleixrm aleixrm commented Nov 28, 2024 •
edited
Loading

Description

Adds NIC configuration missing parameters to the VM template attribute reference.

Based on tf provider docs: https://registry.terraform.io/providers/OpenNebula/opennebula/latest/docs/resources/virtual_machine#method-1

Branches to which this PR applies

  • master
  • one-X.X
  • one-X.X-maintenance
  • Check this if this PR should not be squashed

@aleixrm
f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docum…
3ada867 
…entation

Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
pedroielpi3
pedroielpi3 reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pedroielpi3 pedroielpi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 516 I suggest adding the backticks `` to the key=value pair, i.e.:

NIC DNS server. Please make sure that INHERIT_VNET_ATTR="DNS" is added to /etc/one/oned.conf.

Otherwise looks good to me

@aleixrm
f-#: Fixes key-value format in NIC DNS attribute
dbc07ed 
Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
@aleixrm
Copy link
Member Author

aleixrm commented Nov 28, 2024

For line 516 I suggest adding the backticks `` to the key=value pair, i.e.:

NIC DNS server. Please make sure that INHERIT_VNET_ATTR="DNS" is added to /etc/one/oned.conf.

Otherwise looks good to me

Sorry, I forgot it! Corrected 😄

@aleixrm aleixrm requested a review from pedroielpi3 November 28, 2024 16:31
pedroielpi3
pedroielpi3 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pedroielpi3 pedroielpi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thx

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pedroielpi3 pedroielpi3 pedroielpi3 approved these changes

@rsmontero rsmontero Awaiting requested review from rsmontero

@sk4zuzu sk4zuzu Awaiting requested review from sk4zuzu

@jaimecb jaimecb Awaiting requested review from jaimecb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleixrm @pedroielpi3