Fix incorrectly named lobby option properties. #14532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperrr
approved these changes
Dec 17, 2017
|
One question, though: Could it be that D2k also had Limit Build Area at some point? I faintly remember one mod used to have 8 checkboxes instead of 7, but I'm not sure. |
|
It did at one point, but it was removed when we made the push to match it with the original game. The map designs force a naturally limited build area without requiring the radius. |
|
Does the TD mod even use BuildProvider? If no, then there isn't a point in exposing the buildradius checkbox. |
|
TD does, yes. D2K doesn't, and the checkbox isn't exposed there. |
GraionDilach
approved these changes
Dec 17, 2017
|
I really hope we're not missing some maps with custom rules, but I couldn't find any, so fingers crossed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight from #14359 - I somehow managed to accidentally discard the rule changes associated with the requested renames. This PR fixes the order of the lobby options and reenables cheats by default in TS.