Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve omit_static_information field description #790

Merged

Conversation

FabianPfeuffer
Copy link
Contributor

@FabianPfeuffer FabianPfeuffer commented Mar 18, 2024

Reference to a related issue in the repository

#770

Add a description

A slight improvement and additional information for the description of the SensorViewConfiguration's omit_static_information data field.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar fix, but otherwise looks good.

@pmai pmai force-pushed the DocuOmitStaticInfo branch from 94bf797 to f173310 Compare April 4, 2024 08:58
@pmai pmai self-assigned this Apr 5, 2024
@pmai pmai added this to the V3.7.0 milestone Apr 5, 2024
@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 5, 2024
@jdsika
Copy link
Contributor

jdsika commented Apr 24, 2024

Reviewed for v3.7.0

@pmai
Copy link
Contributor

pmai commented May 6, 2024

CCB 2024-05-06: Merge as-is after way to link to OSMP is checked with ASAM Office/Editors.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 6, 2024
FabianPfeuffer and others added 4 commits May 6, 2024 17:27
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@bmw.de>
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@bmw.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai force-pushed the DocuOmitStaticInfo branch from 31f4070 to 8f99953 Compare May 6, 2024 15:27
@pmai pmai merged commit af8049b into OpenSimulationInterface:master May 6, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants