Disable Annotation RPC

[johann8384]

Maybe this will work for you to disable support for annotation requests? @thatsafunnyname
Fix #823

[johann8384]

@thatsafunnyname This includes your patch from #823 as well as disables the Annotation RPC.

[thatsafunnyname]

Thank you for this. I just added #823 (comment) , in it I report seeing CPUs busy and threads using annotations code in processRow in SaltScanner.java, I am not sure if your changes would avoid this code path, or if an additional guard would be needed around this code.

[thatsafunnyname]

I was wondering if this will get into a 2.3.0 or 2.3.1 release? Thanks.

[johann8384]

Did it solve that issue for you? Of course it is just a workaround, there
is an actual issue we need to fix in the code we are bypassing.

[thatsafunnyname]

I have not tested it. Will it avoid these lines in processRow in SaltScanner.java from being run?

493      List<Annotation> notes = annotations.get(key);
494      if (notes == null) {
495        notes = new ArrayList<Annotation>();
496        annotations.put(key, notes);
497      }

It was removing this code that fixed the issue. Thanks.

[johann8384]

I need to spend a little time on this and come back to it.