Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bot Report Tickets have faulty description syntax #967

Closed
Kissaki opened this issue Nov 26, 2022 · 1 comment · Fixed by #970
Closed

Bot Report Tickets have faulty description syntax #967

Kissaki opened this issue Nov 26, 2022 · 1 comment · Fixed by #970

Comments

@Kissaki
Copy link
Contributor

Kissaki commented Nov 26, 2022

I did not find a bot repository, and this repo has the dom fetchers throw fetch errors, so I assume the bot repo is private. So I am creating this ticket here.

  1. The inline code syntax is used across two lines and list

image

Presumably the error type was supposed to be code-marked, so the closing backtick is missing after it, and the one after the URL is wrong.

  1. Using ' around the URL erroneously links it as part of the href

image

In Markdown <url> can be used for urls as-is - so that should be used for the URL.
@clementbiron
Copy link
Member

Thanks! I think you have created this issue in the right repository because the linked file is here https://github.com/ambanum/OpenTermsArchive/blob/main/src/tracker/index.js

I think @martinratinaud will do it when he gets back from holiday.

Kissaki added a commit to Kissaki/OpenTermsArchive that referenced this issue Nov 30, 2022
@Kissaki
Fix GitHub issue link formatting
aa85fb2 
Previously, errors were reported on a single line, where the inline code-fencing on message worked.

The current logic is:
The html fetcher throws FetchDocumentErrors, with the URL fenced with apostrophe `'`.
Archivist collects these errors in InaccessibleContentError, which produces a multiline error message (generic text + foreach(\n- error)).

Because the message is multiline now, the inline code fencing with backticks no longer worked.

As a side effect, the GitHub URL identification included the closing '` in the URL. Without the ` the ' is not included either.

Dropping the now invalid backticks resolves both issues.

Fixes OpenTermsArchive#967
@Kissaki Kissaki mentioned this issue Nov 30, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GitHub issue link formatting Kissaki/OpenTermsArchive
2 participants
@Kissaki @clementbiron