Use third-party action to set up MongoDB in CI #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract MongoDB start cross-platform
GitHub Actions does not support short SHAs
martinratinaud
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Although I don't mind having a dependency for that kind of need, this one seems to not have that many stars and only one maintainer, so I guess it's the risk.
Checking further down this repo, it seems this user is very proficient in writing github actions as he's done the same for all databases :-)
So I agree to take the risk
Ndpnt
approved these changes
Aug 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset simplifies cross-platform setup, at the expenses of adding a dependency. I am not certain this is worth it, but wanted to consolidate some of my discoveries from #904.