A dep update with migration bug fixes #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* *async*@3.x migration * Using a more applicable statusCodePage for DB S3 connection issue... the error message is still rather vague since it's abstracted several times between function calls but was tested and landed on 404 during *fakeS3* usage. At some point when all callback signatures can be set to `aErr`, `aResults` this should be more explicit... until then preserving existing vagueness. * Revert OpenUserJS#1599 as Fx still uses this in 68.x. TLSv1 EOL will still prevent Opera Presto from even visiting the site. NOTES: * Apparently version 3.x migration is extremely picky now about how Err is generated. i.e. it doesn't allow `true`/`false` anymore like it did in version 2.x. This causes the request to never complete with `async.parallel`. The web spinner and no source is retrieved even though **it was successfully retrieved**. * Been probing/testing dev manually and it seems to be non-sluggish atm with Fx 68.x... perhaps a change from 3.0 to 3.1 of this dep... or even Chromium report since distro version is/was a bit buggy at the time of testing. Post OpenUserJS#1607 OpenUserJS#1520
Martii
added
migration
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 21, 2019
* Do this since I keep running into this between the browsers. * Spell it out in human readable terms. Post OpenUserJS#1661 1599
Martii
added a commit
that referenced
this pull request
Aug 21, 2019
* Do this since I keep running into this between the browsers. * Spell it out in human readable terms. Post #1661 1599 Auto-merge
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aErr,aResultsthis should be more explicit... until then preserving existing vagueness.NOTES:
true/falseanymore like it did in version 2.x. This causes the request to never complete withasync.parallel. The web spinner and no source is retrieved even though it was successfully retrieved.Post #1607 #1520