Add calls to nvlist_destroy to avoid memory leaks #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that. Copying in @kprovost as the initial author of the When approved, we'd ask you to send the patch to the |
|
LGTM It's a common problem with nvlists-in-nvlists, and it's not the first time it's caught me. |
|
THAT was quick, I just see the patch come in via the list - thanks, will take it from there. |
|
haha yeah I sent it just after opening the PR, but wasn't sure the mail was received yet. |
cron2
reviewed
Nov 4, 2024
src/openvpn/dco_freebsd.c
Outdated
| } | ||
|
|
||
| if (remoteaddr) | ||
| { | ||
| nvlist_add_nvlist(nvl, "remote", sockaddr_to_nvlist(remoteaddr)); | ||
| remote_nvl = sockaddr_to_nvlist(remoteaddr); | ||
| nvlist_add_nvlist(nvl, "remote", remove_nvl); |
There was a problem hiding this comment.
remove_nvl is not remote_nvl, so this won't work :-) - I've replied by mail to the list post, and asked for a v2 there.
There was a problem hiding this comment.
oops, sorry for this, I sent the patch too quickly... I'll send a corrected v2 today
remif-stormshield
force-pushed
the
fix/nvlist_leaks_dco
branch
from
882f6b9 to
c2df7d0
Compare
cron2
pushed a commit
that referenced
this pull request
Nov 5, 2024
Some memory leaks were detected by valgrind on the openvpn daemon, using DCO mode on a FreeBSD platform. The leaks are caused by missing nvlist_destroy calls in the file dco_freebsd.c. Calls to nvlist_destroy were added, sometimes using local variables to store nvlist pointers temporarly. A valgrind run on the updated daemon confirmed that the leaks were gone. Github: #636 Signed-off-by: Rémi Farault <remi.farault@stormshield.eu> Acked-by: Kristof Provost <kp@freebsd.org> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <f8845c0c5aa74e5bab537463249a251d@stormshield.eu> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29701.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
cron2
pushed a commit
that referenced
this pull request
Nov 5, 2024
Some memory leaks were detected by valgrind on the openvpn daemon, using DCO mode on a FreeBSD platform. The leaks are caused by missing nvlist_destroy calls in the file dco_freebsd.c. Calls to nvlist_destroy were added, sometimes using local variables to store nvlist pointers temporarly. A valgrind run on the updated daemon confirmed that the leaks were gone. Github: #636 Signed-off-by: Rémi Farault <remi.farault@stormshield.eu> Acked-by: Kristof Provost <kp@freebsd.org> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <f8845c0c5aa74e5bab537463249a251d@stormshield.eu> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29701.html Signed-off-by: Gert Doering <gert@greenie.muc.de> (cherry picked from commit dee0748)
mrbff
pushed a commit
to mandelbitdev/openvpn
that referenced
this pull request
Dec 16, 2024
Some memory leaks were detected by valgrind on the openvpn daemon, using DCO mode on a FreeBSD platform. The leaks are caused by missing nvlist_destroy calls in the file dco_freebsd.c. Calls to nvlist_destroy were added, sometimes using local variables to store nvlist pointers temporarly. A valgrind run on the updated daemon confirmed that the leaks were gone. Github: OpenVPN#636 Signed-off-by: Rémi Farault <remi.farault@stormshield.eu> Acked-by: Kristof Provost <kp@freebsd.org> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <f8845c0c5aa74e5bab537463249a251d@stormshield.eu> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29701.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nvlist memory leaks
Issue
Some memory leaks were detected by valgrind on the openvpn daemon, using DCO mode on a FreeBSD platform.
The leaks are caused by missing nvlist_destroy calls in the file dco_freebsd.c.
Patch content
Calls to nvlist_destroy were added, sometimes using local variables to store nvlist pointers temporarly.
A valgrind run on the updated daemon confirmed that the leaks were gone.