fix: use #!/usr/bin/env bash

[JarvisCraft]

Description

This replaces /bin/bash shebang with a more universal /usr/bin/env bash.

This is required for easier packaging in systems which don't provide the former such as NixOS.

[schwabe]

All the scripts that you are modifying are deprecated. The cmake build system should be used instead.

[JarvisCraft]

@schwabe, thanks for your response!

AFAIKS, openvpn3-linux v22_dev calls some of them while building (namely, version), which happens to be an issue.
This may be due to it using v3.8.5 tag instead of master, but I guess that it would still be better to have these scripts more portable until they are fully eliminated.

[schwabe]

Might be the version one. I would rather like to to see to use #!/bin/sh and make it portable than to use the env hack.

[dsommers]

I'm also willing to consider other approaches in openvpn3-linux to extract the version information from OpenVPN 3 Core, including not depending on any scripts from the Core library. I'm also not a huge fan of the env approach as well.

[JarvisCraft]

I would rather like to to see to use #!/bin/sh and make it portable than to use the env hack.

I like this idea! While I don't consider env a hack (IMO, it is the de facto standard way to write bash-shebangs), I support the idea of migrating to pure sh.

[JarvisCraft]

I've created #317 as an attempt to make all scripts sh-compatible, please take a look at it