Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Undocumented conditions, and clarifying behaviour about certain other… #257

Closed
wants to merge 1 commit into from

Conversation

Lizzie841
Copy link

… conditions

@Spartan322 Spartan322 added the enhancement New feature or request label Dec 21, 2024
@Spartan322
Copy link
Member

Could you rename the commit message (and PR title) so something like Add undocumented country conditions, the second line of the message can also get into the comment clarifications.

@Hop311
Copy link
Contributor

Hop311 commented Dec 21, 2024

Thanks for this, I'm currently reworking the condtion script system in this PR to parse and execute them (although I'll probably merge a draft version first so we can start using the system before going through and making sure every single condition works in the exact right way). I'll copy over the changes you've made here to the other branch 👍

@Lizzie841
Copy link
Author

Damn I didn't knew there was another branch, I'll close this then

@Lizzie841 Lizzie841 closed this Dec 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants