Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix pending owner late overwrite issue #1122

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

ericnordelo
Copy link
Member

No description provided.

@ericnordelo ericnordelo requested review from ggonzalez94 and andrew-fleming and removed request for ggonzalez94 August 29, 2024 14:33
@ericnordelo ericnordelo changed the title Fix pending owner late overwrite issue #1119 Fix pending owner late overwrite issue Aug 29, 2024
Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

packages/access/src/tests/test_ownable.cairo Outdated Show resolved Hide resolved
packages/access/src/tests/test_ownable_twostep.cairo Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left a couple comments

packages/access/src/ownable/ownable.cairo Show resolved Hide resolved
ericnordelo and others added 4 commits August 29, 2024 19:58
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd also include the removal of _accept_ownership to the changelog

@ericnordelo ericnordelo merged commit ef87d78 into OpenZeppelin:main Aug 30, 2024
6 checks passed
@ericnordelo ericnordelo deleted the fix/ownable-two-step-2 branch August 30, 2024 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants