-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump scarb to 2.8.3 #1166
Bump scarb to 2.8.3 #1166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 57 57
Lines 1375 1375
=======================================
Hits 1222 1222
Misses 153 153 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## Unreleased | |||
|
|||
### Changed | |||
|
|||
- Bump scarb to v2.8.3 (#1166) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we usually specify this as a breaking change? Or maybe 2.8.3
does not have any breaking changes and we are good this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't have any breaking change, so I didn't add it to the breaking sections. With this said, the compiler version sometimes doesn't follow semver, and we've had issues with a minor bump breaking, and that's why we usually add it to the breaking section. This time is just a scarb bump, and not a cairo version bump, so it is safer.
Bump scarb to the latest version.