-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix transient deps #1249
Fix transient deps #1249
Conversation
CHANGELOG.md
Outdated
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Changed (Breaking) | |||
|
|||
- Move `openzeppelin_utils` from dev-dep to dep in governance manifest (#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change breaking? This looks more like a Fixed entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, fixed!
We have a few more to fix:
Also (non-blocking):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1247.
There's also an
openzeppelin_utils
dev dep in the finance manifest. It's currently only being used in tests (here). It's probably better not to include it as a dep in the finance package since it's not absolutely necessary, but it's something to consider to be safePR Checklist