Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix transient deps #1249

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

andrew-fleming
Copy link
Collaborator

Fixes #1247.

There's also an openzeppelin_utils dev dep in the finance manifest. It's currently only being used in tests (here). It's probably better not to include it as a dep in the finance package since it's not absolutely necessary, but it's something to consider to be safe

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

CHANGELOG.md Outdated
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed (Breaking)

- Move `openzeppelin_utils` from dev-dep to dep in governance manifest (#)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change breaking? This looks more like a Fixed entry.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, fixed!

@ericnordelo
Copy link
Member

We have a few more to fix:

  • In access, openzeppelin_utils is added as a dependency but it is not used.
  • In finance, openzeppelin_utils must be added as a dev-dependency.

Also (non-blocking):

  • In openzeppelin_account there are two use openzeppelin_account:: to be replaced by use crate::
  • In openzeppelin_finance there is a use openzeppelin_finance:: to be replaced by use crate::

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit cb41a36 into OpenZeppelin:main Dec 5, 2024
6 checks passed
@andrew-fleming andrew-fleming deleted the fix-transient-deps branch December 5, 2024 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transient dependencies
2 participants