Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Governor to governance README #1250

Merged

Conversation

ericnordelo
Copy link
Member

No description provided.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment on lines 14 to 16
- [`TimelockControllerComponent`](https://docs.openzeppelin.com/contracts-cairo/0.20.0-rc.0/api/governance#TimelockControllerComponent)
- [`GovernorComponent`](https://docs.openzeppelin.com/contracts-cairo/0.20.0-rc.0/api/governance#GovernorComponent)
- [`VotesComponent`](https://docs.openzeppelin.com/contracts-cairo/0.20.0-rc.0/api/governance#VotesComponent)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we're removing timelock from here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the API, I think we should include a list item link for GovernorExtensions

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit 6449ed6 into OpenZeppelin:main Dec 6, 2024
6 checks passed
@ericnordelo ericnordelo deleted the docs/update-governance-readme branch December 6, 2024 17:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants