Apply suggestions from code review

Co-authored-by: Ernesto García <ernestognw@gmail.com>
OpenZeppelin · Mar 22, 2023 · ee560d0 · ee560d0
1 parent 597edc0
commit ee560d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/contracts/access/manager/AccessManager.sol b/contracts/access/manager/AccessManager.sol
@@ -107,7 +107,7 @@ contract AccessManager is IAccessManager, AccessControlDefaultAdminRules {
      * @dev Returns true if the caller can invoke on a target the function identified by a function selector.
      * Entrypoint for {AccessManaged} contracts.
      */
-    function canCall(address caller, address target, bytes4 selector) public view returns (bool) {
+    function canCall(address caller, address target, bytes4 selector) public view virtual returns (bool) {
         bytes32 allowedGroups = getFunctionAllowedGroups(target, selector);
         bytes32 callerGroups = getUserGroups(caller);
         return callerGroups & allowedGroups != 0;

diff --git a/test/access/manager/AccessManaged.test.js b/test/access/manager/AccessManaged.test.js
@@ -38,15 +38,15 @@ contract('AccessManaged', function (accounts) {
   describe('restricted', function () {
     const selector = web3.eth.abi.encodeFunctionSignature('restrictedFunction()');
 
-    it('allows if authority says true', async function () {
+    it('allows if authority returns true', async function () {
       const authority = await SimpleAuthority.new();
       const managed = await AccessManaged.new(authority.address);
       await authority.setAllowed(user, managed.address, selector);
       const restricted = await managed.restrictedFunction({ from: user });
       expectEvent(restricted, 'RestrictedRan');
     });
 
-    it('reverts if authority says false', async function () {
+    it('reverts if authority returns false', async function () {
       const authority = await SimpleAuthority.new();
       const managed = await AccessManaged.new(authority.address);
       await expectRevert(managed.restrictedFunction({ from: user }), 'AccessManaged: authority rejected');