Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make quorum behavior match GovernorBravo #2974

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Nov 15, 2021

See GovernorBravoDelegate.sol#L203: if for votes are strictly less than quorum votes, the proposal is defeated. In other words, the quorum is reached if for votes are greater than or equal to quorum votes.

@frangio frangio requested a review from Amxx November 15, 2021 21:04
@frangio frangio changed the title Make quorum inclusive minimum in GovernorCompatibilityBravo Make quorum behavior match GovernorBravo Nov 15, 2021
@Amxx Amxx merged commit a94cf05 into OpenZeppelin:master Nov 16, 2021
@frangio frangio deleted the quorum-reached-gt branch November 16, 2021 13:07
frangio added a commit that referenced this pull request Nov 16, 2021
* Make quorum inclusive minimum in GovernorCompatibilityBravo

* add PR link

(cherry picked from commit a94cf05)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants