Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix arbitrum L1 to L2 crosschain call detection #3578

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Fix arbitrum L1 to L2 crosschain call detection #3578

merged 3 commits into from
Jul 25, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 25, 2022

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

frangio
frangio previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests need to be fixed though.

@frangio
Copy link
Contributor

frangio commented Jul 25, 2022

Updated the changelog, assuming we will release this as 4.7.2.

@Amxx Amxx enabled auto-merge (squash) July 25, 2022 20:08
@Amxx Amxx disabled auto-merge July 25, 2022 20:08
@Amxx
Copy link
Collaborator Author

Amxx commented Jul 25, 2022

Do we need a changelog entry / notice ?

@frangio
Copy link
Contributor

frangio commented Jul 25, 2022

Personally I think the changelog entry I wrote down is ok. For a larger warning we will have an advisory.

@Amxx Amxx merged commit 81336ae into OpenZeppelin:master Jul 25, 2022
@Amxx Amxx deleted the fix/crosschain/arbitrum branch July 25, 2022 20:42
frangio pushed a commit that referenced this pull request Jul 26, 2022
@Amxx @frangio
Fix arbitrum L1 to L2 crosschain call detection (#3578)
4337192 
* Fix arbitrum L1 to L2 crosschain call detection

* fix BridgeArbitrumL2Mock

* update changelog

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
(cherry picked from commit 81336ae)
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
@ronhuafeng @frangio
Fix arbitrum L1 to L2 crosschain call detection (OpenZeppelin#3578)
b48c2bf 
* Fix arbitrum L1 to L2 crosschain call detection

* fix BridgeArbitrumL2Mock

* update changelog

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio