Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use actionlint on GitHub Actions workflows #3953

Merged
merged 9 commits into from
Jan 13, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jan 12, 2023

Actionlint is a linter for GitHub Actions workflows. It can detect security problems like:

I set this to run only when the workflows change because it won't happen often and we don't want to see the check all the time.

This is what it would look like on a workflow with errors:

image

Our existing workflows don't have any errors. (Great!)

One thing to note is that actions like our setup action aren't linted. There is a feature request for this (rhysd/actionlint#46).

@frangio frangio changed the title Use actionlint to lint GitHub Actions workflows Use actionlint on GitHub Actions workflows Jan 12, 2023
@frangio frangio requested a review from ernestognw January 12, 2023 21:57
@frangio frangio marked this pull request as ready for review January 12, 2023 21:57
ernestognw
ernestognw previously approved these changes Jan 12, 2023
.github/workflows/actionlint.yml Outdated Show resolved Hide resolved
@frangio frangio requested a review from ernestognw January 12, 2023 23:15
@frangio frangio merged commit d89e51a into OpenZeppelin:master Jan 13, 2023
@frangio frangio deleted the actionlint branch January 13, 2023 14:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants