Bump and pin Forge Std submodule

[PaulRBerg]

Bumps and also pins forge-std to v1.

The benefit of pinning is that it leads to more predictable repo checkouts.

We use the release-v4.8 branch (solidity-generators) in a project with many git submodules. Pinning your version of forge-std to v1 helps reduce the installation time when pulling a fresh copy of the repo for the first time, because it leads to the same commit for forge-std.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 712f3c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[frangio]

I'm not sure I understand why this helps your setup, unless we always keep the commit in sync with the one you have checked out in your own repo. What is the command that you use to initialize the git submodules? Isn't the problem that you are doing a "recursive" clone of submodules?

[PaulRBerg]

unless we always keep the commit in sync with the one you have checked out in your own repo

This is exactly the goal here; pinning the submodule to the v1 branch helps with that. Updating submodules will not change forge-std in your repo if you pin the branch to v1 in .gitmodules.

There are fewer changes made to the v1 branch of Forge Std than there are on master:

foundry-rs/forge-std#275

[frangio]

I see. Git submodules are so bad for dependency management... 😅 I hope the v1 branch remains updated. They don't seem to have automated that.

I will merge this in master and cherry-pick on the release branch.

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

[frangio]

Cherry-picked on release-v4.8 in 9eee01c.

[PaulRBerg]

Thanks for merging, @frangio!

I hope the v1 branch remains updated. They don't seem to have automated that.

Yeah @mds1 and I will make sure to do that 🫡