Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optimize array allocation in ERC1155 #4196

Merged
merged 10 commits into from
Jun 2, 2023
Merged

Optimize array allocation in ERC1155 #4196

merged 10 commits into from
Jun 2, 2023

Conversation

RenanSouza2
Copy link
Contributor

@RenanSouza2 RenanSouza2 commented Apr 26, 2023 •
edited
Loading

As discussed in the issue #3940 these are some optimizations

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6f9b86a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RenanSouza2 RenanSouza2 mentioned this pull request Apr 26, 2023
Closed
@frangio frangio changed the base branch from next-v5.0 to master June 1, 2023 22:55
@frangio frangio changed the title Array optimization ERC1155 Optimize array allocation in ERC1155 Jun 1, 2023
@frangio frangio requested a review from a team June 1, 2023 23:00
@frangio
Copy link
Contributor

frangio commented Jun 1, 2023

Hi @RenanSouza2, sorry for the silence, are you interested in finishing the work on this PR?

@RenanSouza2
Copy link
Contributor Author

Member

yes, I'll finish it

@clauBv23 clauBv23 mentioned this pull request Jun 2, 2023
Merged
3 tasks
frangio
frangio approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frangio frangio merged commit 5cef83d into OpenZeppelin:master Jun 2, 2023
@RenanSouza2 RenanSouza2 deleted the array-optimization-tests branch June 2, 2023 14:56
This was referenced Jun 15, 2024
Open
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@RomulousApollo RomulousApollo mentioned this pull request Jul 9, 2024
Open
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RomulousApollo RomulousApollo mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 8, 2024
Open
Open
This was referenced Nov 9, 2024
Merged
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

@Amxx Amxx Amxx left review comments

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RenanSouza2 @frangio @Amxx @ernestognw