-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add internal functions inside modifiers #4472
Add internal functions inside modifiers #4472
Conversation
…xy and the notDelegated code with a _checkNotDelegated internal function
🦋 Changeset detectedLatest commit: e7bf564 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
couldn't able to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @worksofallwin! I'm not sure yet about the docs. Perhaps we should move the description from the modifiers to the internal functions.
Let's wait for other team members input :)
Curious to know, do you see any specific error? |
Sure! If anything has to be updated, let me know. |
Looks good to me but I agree with @ernestognw's suggestions. |
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
@ernestognw I have committed the suggested changes. |
LGTM, still missing the changeset though |
@ernestognw @Amxx
LMK, if this is the right way, If not can you help with any documentation on how to do this? |
The command is |
@Amxx Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #4466
Some modifiers could use internal functions to reduce code size impact
_checkGovernance
,_checkProxy
,_checkNotDelegated
and_checkInitializing
internal functions has been added.PR Checklist
npx changeset add
)