Clean up npm package #904
Merged
Clean up npm package #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
force-pushed
the
ignore-files-for-npm
branch
from
0cb96ed to
71d9c65
Compare
frangio
changed the title
shrugs
approved these changes
Apr 26, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#This PR will result in ignoring everything but the official contracts and the tests for inclusion in the npm package.
I'm marking this as in progress because I would like to tackle #326 as well, by compiling the test helpers before including them in the package.I'm keeping the entire tests folder as-is, because of the test helpers and because there are some behavior test files that could be in use by some users. We should look into this though because technically those things have non-dev dependencies (truffle, mocha, chai, etc.).
Additionally I'm removing some unnecessary dependencies.