fix(pipelineTriggers): handle invalid constraint regexes (#1209) (#9)

echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/artifacts/ArtifactMatcher.java

@@ -24,6 +24,7 @@
 import java.util.*;
 import java.util.function.Predicate;
 import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
 import java.util.stream.Collectors;
 import lombok.extern.slf4j.Slf4j;
 
@@ -129,7 +130,19 @@ public static boolean isJsonPathConstraintInPayload(final Map constraints, final
   }
 
   private static boolean matches(String us, String other) {
-    return Pattern.compile(us).asPredicate().test(other);
+    Pattern p;
+    try {
+      p = Pattern.compile(us);
+    } catch (PatternSyntaxException ex) {
+      log.error(
+          "Invalid regex pattern for constraint, will never match any payload: \""
+              + us
+              + "\": "
+              + ex.getMessage(),
+          ex);
+      return false;
+    }
+    return p.asPredicate().test(other);
   }
 
   private static boolean anyMatch(String us, List<String> values) {

echo-pipelinetriggers/src/test/groovy/com/netflix/spinnaker/echo/pipelinetriggers/artifacts/ArtifactMatcherSpec.groovy

@@ -39,6 +39,10 @@ class ArtifactMatcherSpec extends Specification {
     "one": "o"
   ]
 
+  def invalidConstraint = [
+    "one": "[one,two"
+  ]
+
   def constraintsOR = [
     "one": ["uno", "one"]
   ]
@@ -160,6 +164,14 @@ class ArtifactMatcherSpec extends Specification {
     !result
   }
 
+  def "no match when constraint invalid"() {
+    when:
+    boolean result = ArtifactMatcher.isConstraintInPayload(invalidConstraint, matchPayload)
+
+    then:
+    !result
+  }
+
   def "matches when payload value is in a list of constraint strings"() {
     when:
     boolean result = ArtifactMatcher.isConstraintInPayload(constraintsOR, matchPayload)
@@ -224,6 +236,14 @@ class ArtifactMatcherSpec extends Specification {
     !result
   }
 
+  def "no match when constraint not valid using Jsonpath"() {
+    when:
+    boolean result = ArtifactMatcher.isJsonPathConstraintInPayload(invalidConstraint, matchPayload)
+
+    then:
+    !result
+  }
+
   def "matches when payload value is in a list of constraint strings using Jsonpath"() {
     when:
     boolean result = ArtifactMatcher.isJsonPathConstraintInPayload(constraintsOR, matchPayload)