Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add more info when fail to import flash attn #704

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

wheresmyhair
Copy link
Collaborator

When importing "flash_attn", there's a possibility of encountering errors other than "ModuleNotFound".

These errors will also be ignored by the try/except clause, potentially leading users to mistakenly believe that they have successfully imported flash_attn.

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@research4pan research4pan merged commit f28d672 into main Mar 26, 2024
0 of 2 checks passed
@research4pan research4pan deleted the yizhenjia-minor-fixes branch March 31, 2024 09:42
@research4pan research4pan restored the yizhenjia-minor-fixes branch March 31, 2024 09:42
@wheresmyhair wheresmyhair deleted the yizhenjia-minor-fixes branch April 1, 2024 02:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants