Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Model] hf model modification and inheritance change #852

Merged
merged 4 commits into from
Jun 9, 2024
Merged

[Model] hf model modification and inheritance change #852

merged 4 commits into from
Jun 9, 2024

Conversation

wheresmyhair
Copy link
Collaborator

@wheresmyhair wheresmyhair commented Jun 8, 2024 •
edited
Loading

Description

Move some methods in hf_decoder_model and hf_text_regression to hf_model_mixin

Pipeline Tests

  1. Full-Finetune
    ft

  2. LISA
    lisa

  3. LoRA
    LoRA

  4. QLoRA
    qlora

@wheresmyhair wheresmyhair marked this pull request as ready for review June 8, 2024 17:58
research4pan
research4pan approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The code is much cleaner now, some minor suggestions on style that can be improved later

src/lmflow/args.py

[Style] line 81-93: No need for blank lines since the arguments are already separated by indentation, which is more compact.

@research4pan research4pan merged commit c6e2ecc into main Jun 9, 2024
2 checks passed
@wheresmyhair wheresmyhair deleted the yizhenjia-hfmodelmix branch June 9, 2024 12:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@research4pan research4pan research4pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wheresmyhair @research4pan