Add alpha erase blend mode #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! If we want to be consistent with other software though, I think we should keep the name "Subtract" as it is, and the new mode should be called "Erase", as they are not quite the same. Erase should also be together with Normal, as its not considered an Inversion type of blend mode. In the documentation you linked it is listed under the Normal layer modes group, while Subtract is listed under the Inversion layer modes https://docs.gimp.org/en/layer-mode-group-inversion.html |
|
Done |
OverloadedOrama
approved these changes
Oct 12, 2024
OverloadedOrama
merged commit c21e089
into
Orama-Interactive:master
3 of 4 checks passed
OverloadedOrama
added a commit
that referenced
this pull request
Oct 22, 2024
… pxo files The addition of the erase blend mode from #1117 resulted in loading pxo files from v1.0-v1.0.3 to have incorrect blend modes in their layers, if they are set to anything below normal, because the values of the `BaseLayer.BlendModes` enumerator changed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works same as the Erase mode in https://docs.gimp.org/en/gimp-concepts-layer-modes.html (
Figure 8.12. Example for layer mode “Erase”)An "Erase" layer blend mode or effect would easily skip a step of manual labor when, for example, making opaque shapes with transparent icons within.
effect-.2.mp4
effect-.2.mp4