Stepped process: convert current step to plain text for better accessibility #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewenLeHo
added
v5
👂 accessibility
📖 documentation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
This PR should be discussed as well with the designers just to validate the behavior; IMO this behavior (+ the states) should be described in the DSM.
Another thing about the rendering, the stepped process item shouldn't be underlined when hovering it since it is not a link anymore.
MewenLeHo
force-pushed
the
main-mlh-fix-accessibility-steooed-process
branch
from
a0dd678 to
d5e0be0
Compare
MewenLeHo
force-pushed
the
main-mlh-fix-accessibility-steooed-process
branch
from
d5e0be0 to
b916dfe
Compare
julien-deramond
added
👌 OK Accessibility
👌 OK Design
and removed
awaiting-reply
upcoming a11y review
upcoming design review
labels
|
Kudos, SonarCloud Quality Gate passed!
|
julien-deramond
approved these changes
Nov 30, 2022
julien-deramond
deleted the
main-mlh-fix-accessibility-steooed-process
branch
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert link to current step to plain text.
Motivation & Context
The current step can't be a link because it's the active page. In addition it should not be possible to focus it.
I converted it to plain text by removing the unnecessary
href="#"attribute.Types of change
Live previews
Checklist
npm run lint)