Carousel's pause/play button must be placed first #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MewenLeHo
commented
Jan 16, 2023
MewenLeHo
force-pushed
the
main-mlh-position-pause-play-button-first
branch
from
42ca288 to
e6daa42
Compare
26 tasks
louismaximepiton
requested changes
Jan 20, 2023
louismaximepiton
requested changes
Jan 31, 2023
MewenLeHo
force-pushed
the
main-mlh-position-pause-play-button-first
branch
from
f05eaf4 to
0d630c3
Compare
|
@Franco-Riccitelli: is the 'ok design' label ok for you? |
|
Not linked to this PR but https://boosted.netlify.app/docs/5.3/components/carousel/#indicators doesn't start the auto-animation, which can be correct but we shouldn't see any "gauge animation". There's maybe already an issue in our backlog but I preferred to mention it here as well. If not, could you please create an issue and put it in the next sprint? |
julien-deramond
suggested changes
Feb 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #1578
Description
Change the location of the pause/play button.
Motivation & Context
For better accessibility, pause/play button must be placed first in order to inform screen readers users that they have a way to control the incoming carousel.
Types of change
Live previews
https://deploy-preview-1763--boosted.netlify.app/docs/5.3/components/carousel/#with-pauseplay-button
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge