Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add marker for active link in footer #1859

Merged
merged 22 commits into from
May 22, 2023
Merged

Add marker for active link in footer #1859

merged 22 commits into from
May 22, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Feb 27, 2023 •
edited
Loading

Related issues

Closes #1717

Description

Add a marker to active link when the link is in the footer.

Motivation & Context

Improve accessibility in Boosted.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

https://deploy-preview-1859--boosted.netlify.app/docs/5.3/components/footer/#service-bar
https://deploy-preview-1859--boosted.netlify.app/docs/5.3/components/footer/#mandatory-terms-and-conditions-bar
https://deploy-preview-1859--boosted.netlify.app/docs/5.3/examples/form/

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit fbf6815
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/646b4ee2c9ec280008cde391
😎 Deploy Preview https://deploy-preview-1859--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo
Copy link
Contributor Author

Here is the actual design, a simple underline as we discussed during our weekly specs meetings:
screenshot-deploy-preview-1859--boosted netlify app-2023 02 27-11_30_06

What are your thoughts on this @Aniort and @Franco-Riccitelli?

@Aniort Aniort self-requested a review April 21, 2023 14:09
Aniort
Aniort approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine !

@Franco-Riccitelli
Copy link
Member

Looks good to me.

louismaximepiton

This comment was marked as outdated.

# to view

louismaximepiton

This comment was marked as outdated.

# to view

@MewenLeHo MewenLeHo mentioned this pull request May 2, 2023
Merged
13 tasks
@MewenLeHo MewenLeHo requested a review from julien-deramond May 12, 2023 09:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

julien-deramond
julien-deramond approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just moved the migration not to the right place in v5.3.0 instead of v5.2.1 via fbf6815

@julien-deramond julien-deramond merged commit 4d515be into main May 22, 2023
@julien-deramond julien-deramond deleted the main-mlh-active-link-footer branch May 22, 2023 11:28
@julien-deramond julien-deramond mentioned this pull request May 22, 2023
Closed
isabellechanclou pushed a commit that referenced this pull request Jul 5, 2023
@MewenLeHo @julien-deramond @isabellechanclou
feat(footer): special rendering for active links for better a11y (#1859)
374f586 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Aniort Aniort Aniort approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
👂 accessibility 📖 documentation Improvements or additions to documentation 👌 OK Accessibility 👌 OK Design v5
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Active link marker in footer navigation
5 participants
@MewenLeHo @Franco-Riccitelli @Aniort @julien-deramond @louismaximepiton