-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docs: Add caption in captions' html examples #2033
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Just a question: the captions are present in Bootstrap (https://getbootstrap.com/docs/5.2/content/tables/#captions) meaning they were intentionnaly removed from Boosted. Do we know why? And when?
Because if it was trully intentional there was probably a reason to do it? (honestly I don't see any good reason to do it 🤔 )
Good question... I've been digging: it seems it comes from #859 @louismaximepiton @julien-deramond Was it an error to remove captions in displayed code? |
(answer from LM who has issues with Github access these days)
Good catch Hannah, it comes from #859. FWIW, I tried to bring much Bootstrap commits inside this PR such as the table shortcode so it had many impacts on the table.md and I missed the one here. It was surely unintentional to remove the caption code in the demo caption section so it would be great to see it back in the doc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with LM's answer.
Kudos, SonarCloud Quality Gate passed! |
Add caption in captions' html examples so that developers can see how to use it
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Description
Add captions in html code example
Motivation & Context
In captions' section, we have 2 examples with caption, but no caption in the html example.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge