Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docs: Overflow remove .bg-white #2671

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 2, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Following #2664.

Description

Change .bg-white to .bg-body to handle dark mode.

Motivation & Context

This change was introduced by https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1751/files#diff-dbf24c07dc13b7fbbb26a7a91a4d9abfad4ba4a385cf00de0c327d6461034b2a and it seems like it went out of our vision for a long time now.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 📖 documentation Improvements or additions to documentation 🧩 enhancement labels Aug 2, 2024
@julien-deramond julien-deramond self-requested a review August 2, 2024 09:13
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 8d2b638
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66aca31471592e0008e81968
😎 Deploy Preview https://deploy-preview-2671--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit 6b3e079 into main Aug 2, 2024
19 checks passed
@julien-deramond julien-deramond deleted the main-lmp-change-bg-class branch August 2, 2024 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
📖 documentation Improvements or additions to documentation 🧩 enhancement v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants