[OUDS] Add migration guides to the color tokens PR #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
📖 documentation
louismaximepiton
force-pushed
the
ouds/main-lmp-tokens-colors-migration-guides
branch
2 times, most recently
from
4f8ad55 to
5792fd3
Compare
Base automatically changed from
ouds/main-lmp-tokens-colors-bootstrap-compatibility
to
ouds/main-lmp-tokens-colors
January 27, 2025 15:00
vprothais
reviewed
Jan 27, 2025
| 15. `.bg-warning-subtle` (that shouldn't have been used) → `.bg-status-warning-muted` or `.bg-status-accent-muted` depending on your context | ||
| 16. `.bg-body` → `.bg-primary` | ||
| 17. `.bg-body-secondary` → `.bg-secondary` | ||
| 18. `.bg-body-tertiary` → `.bg-secondary` |
There was a problem hiding this comment.
Should this one have been used since is not in the documentation ?
There was a problem hiding this comment.
It shouldn'e but we never know what people are using in their website, I tried to cover all cases.
louismaximepiton
force-pushed
the
ouds/main-lmp-tokens-colors-migration-guides
branch
from
5792fd3 to
eafa409
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vprothais
approved these changes
Jan 29, 2025
vprothais
merged commit 7ea0ff4
into
ouds/main-lmp-tokens-colors
13 of 14 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
NA
Description
Remaining tasks and questions
Tasks:
Done list
The following was done in the PR:
To be done after the PR is merged
Motivation & Context
Types of change
Live previews