Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OrchardHelper content APIs should be accessible without namespace #17189

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Dec 9, 2024

All IOrchardHelper extension methods are easily accessible without a namespace in RazorPages or MVC views, except Content APIs this PR make them consistent with others

@hishamco hishamco requested a review from ns8482e December 13, 2024 19:38
@gvkries
Copy link
Contributor

gvkries commented Dec 17, 2024

I agree with this, but it's again a breaking change.

@ns8482e
Copy link
Contributor

ns8482e commented Dec 23, 2024

Please don't change namespace, instead update module/theme templates to include OrchardCore as global using

@hishamco
Copy link
Member Author

Which module do you mean? But the change is necessary to make things consistent, 3.0.0 is the only way to accept such breaking change

@gvkries
Copy link
Contributor

gvkries commented Feb 21, 2025

Moving the helper class out of the module, as done in PR #17414, should be done at the same time.

@hishamco
Copy link
Member Author

Do you mean out of OC.Contents? If yes this mean we should revise the other helpers coz I'm sure that I saw some inside the module projects

If the intend is to avoid module reference once we use them. I might create another PR after to make things consistent

@hishamco hishamco requested a review from gvkries February 22, 2025 04:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants