Custom Warlock Pact Boons #150
Conversation
…uilder drop-down menu, and an icon for the Pact Boons tab in My Content
datdamnzotz
requested review from
datdamnzotz,
codeGlaze,
Demonsthere,
DivertedCircle and
MeanderingCode
datdamnzotz
added
area/application
|
Woah, that's pretty nice :D But I think one piece is missing, the requirements for Invocations. Do you have some idea how to add those? |
|
I think I have an idea on how to do it but I'm planning on making that a separate mass update; Invocations are missing them too and feats could do with an improved one |
This reverts commit 9c513df. Doesn't work
|
That's about all I can do on the "mapcat">"concat(map...) subject. The parameter change should be done as a different fix, I think, as it's unrelated to this bit of code. It's more on the side of general plugin handling, rather than the pact builder itself |
|
I keep editing and adding to this, whoops :P I guess it's free reign until it's actually pulled tho 🤷♂ |
|
@marloso2 Does this PR still work, given its age? If it does, I'm ok with approving it, though I haven't personally tested it. Doesn't seem like anyone else is going to weigh in on it, at this point. |
|
Yeah, afaik everything's working, and even better so with the added Edit button. I'll just check through all the comments again to see if I've missed anything |
|
Yeah, that's that. All seems good and I don't think I'll be adding anything to this |
Adresses issue #125
Created a Pact Builder page in the My Content drop down menu of builders. I opted not to put it on the splash page as that's already messy enough and there's no need for it; It's not a particularly commonly homebrewed thing
Orcbrews and My Content sources can now have Pact Boons saved, exported and imported into the site. I went for the cursed-star.svg icon because it sorta matches with the Eldritch Invocations icon as well.
Slight issue that I didn't manage to fix - On the character builder there's no edit button next to the homebrew Pact Boons. This isn't a big deal and it doesn't hinder the utility of this PR but it might be something to bear in mind for a QoL improvement in the future.