List treasure on Character Viewer

[marloso2]

The Character Viewer shows the character's Money and Gems under a Treasure subheading in the Equipment tab

[datdamnzotz]

Also now I am not too sure about the sorting. Maybe we should leave it out, or recode it for ordering like the book does.

[KingMob]

There's a mismatch between the component fn params and the render fn params. with-let is probably your best solution

[marloso2]

So that's the suggetsed improvements. Must say, I completely missed the .pointer. And thanks for the r/with-let, King. Either way, that leaves the question - Do we want alphabetical sorting, or no? I'm not sure yet how to do sorting to a custom order so someone else would have to do that once this is pulled

[datdamnzotz]

Do we want alphabetical sorting, or no? I'm not sure yet how to do sorting to a custom order so someone else would have to do that once this is pulled

I would vote for if we can do it like the book sorts it.

[marloso2]

I'm not sure yet how to do sorting to a custom order

I would vote for if we can do it like the book sorts it.

Welp, as I said, I have absolutely no idea how to do that so somebody else would have to 😋

[codeGlaze]

Wait, isn't treasure already sorted in a logical order?

[marloso2]

By default it's sorted in the order that it's added to your character. But we've also got the code for alphabetical sorting

[KingMob]

The treasure is stored in equipment.cljc in book order by default, but that doesn't help us sort a character's treasures. (Well, we could fake it by searching on strings and comparing indices, but that's slow and ugly.)

Instead, we should just make the order explicit, so it'll be available for sorting with sort-by.

E.g.:

(def treasure
  [{:key :cp
    :name "Copper Pieces (CP)"}
   {:key :sp
    :name "Silver Pieces (SP)"}
   {:key :ep
    :name "Electrum Pieces (EP)"}
   {:key :gp
    :name "Gold Pieces (GP)"}
   ...

becomes

(def treasure
  [{:key :cp
    :name "Copper Pieces (CP)"
    :rank 1}
   {:key :sp
    :name "Silver Pieces (SP)"
    :rank 2}
   {:key :ep
    :name "Electrum Pieces (EP)"
    :rank 3}
   {:key :gp
    :name "Gold Pieces (GP)"
    :rank 4}
   ...

and then if we have a sequence of character treasures with the :rank field in them, we can do:

(sort-by :rank some-character-treasure-vector)

I think that, or something similar, should work.

[marloso2]

Ahh, that's quite a good solution, actually. I'm working on something else right now but next time I get fed up with that I'll come back to this PR and add the ordering 😋

[KingMob]

Another alternative is to place the character's treasure into a sorted map/set with sorted-map-by / sorted-set-by. Then, when you want to iterate over the map, they'll come out sorted.

[datdamnzotz]

@marloso2 see #231 as well.

[datdamnzotz]

I'm going to merge this to get the fixes into the branch. I don't think sorting should hold this up.

[KingMob]

Sorry @datdamnzotz, been real busy with life lately.

[codeGlaze]

@KingMob we've all been pretty quiet. I assumed that was the case all around