Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Linting #425

Merged
merged 9 commits into from
Sep 17, 2020
Merged

Linting #425

merged 9 commits into from
Sep 17, 2020

Conversation

Pireax
Copy link

@Pireax Pireax commented Jul 16, 2020 •
edited
Loading

Description:

Add linting support to the codebase. Can be included into the CI pipeline later when all linting issues are fixed. Also already fixes some linting issues.
EDIT: Has been added to the pipeline and remaining issues were fixed

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@Pireax Pireax force-pushed the linting branch 2 times, most recently from b8edd49 to 4453d39 Compare July 16, 2020 22:33
@datdamnzotz
Copy link

See #426

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself area/deployment Tasks related to deployment mechanism enhancement New feature or request area/ci Continuos Integration tasks labels Jul 20, 2020
datdamnzotz
datdamnzotz requested changes Aug 19, 2020
View reviewed changes
project.clj Outdated
@@ -93,8 +95,6 @@
;; Compress the output?
:pretty-print? false}}]}

:prep-tasks [["garden" "once"]]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pireax
Breaks production build as it doesn't create the CSS
image

Please put this back in.

@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Aug 19, 2020
@datdamnzotz datdamnzotz linked an issue Aug 19, 2020 that may be closed by this pull request
Linting #426
Closed
@datdamnzotz datdamnzotz merged commit 62cff7e into Orcpub:develop Sep 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@datdamnzotz datdamnzotz datdamnzotz approved these changes

Assignees

@Pireax Pireax

Labels
area/application Task related to orcpub application itself area/ci Continuos Integration tasks area/deployment Tasks related to deployment mechanism enhancement New feature or request
Projects
None yet
Milestone
2.5.0.17
Development

Successfully merging this pull request may close these issues.

Linting
2 participants
@Pireax @datdamnzotz