Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added EMAIL_FROM_ADDRESS environment variable. #456

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Added EMAIL_FROM_ADDRESS environment variable. #456

merged 4 commits into from
Sep 29, 2020

Conversation

defib
Copy link

@defib defib commented Sep 28, 2020 •
edited
Loading

Description:

Added a new Environment Variable: EMAIL_FROM_ADDRESS

This allows you to set the email address orc pub is sending from. Changing it from the hardcoded 'no-reply@orcpub.com' to what ever you want.

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

datdamnzotz
datdamnzotz requested changes Sep 28, 2020
View reviewed changes
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add to the footer and close out #13 in this one as well?

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself enhancement New feature or request labels Sep 28, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Sep 28, 2020
@datdamnzotz datdamnzotz linked an issue Sep 28, 2020 that may be closed by this pull request
Add EMAIL_FROM_ADDRESS environment variable #457
Closed
datdamnzotz
datdamnzotz approved these changes Sep 29, 2020
View reviewed changes
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@datdamnzotz datdamnzotz merged commit 81896cd into Orcpub:develop Sep 29, 2020
@defib defib deleted the change-from-email branch September 29, 2020 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@datdamnzotz datdamnzotz datdamnzotz approved these changes

Assignees

@defib defib

Labels
area/application Task related to orcpub application itself enhancement New feature or request
Projects
None yet
Milestone
2.5.0.17
Development

Successfully merging this pull request may close these issues.

Add EMAIL_FROM_ADDRESS environment variable
2 participants
@defib @datdamnzotz