fix: trim the trailing params in SourcePRURL #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ran <huangran.alex@gmail.com>
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
|
@ran-huang 👋🏼 Thanks for your work on improving the URL handling in the CreateTransPR function. I have reviewed this PR and created a patch ran-huang#1 with some modifications that I think could be more compatible with future releases and updates. PTAL |
I have reviewed your patch and it looks excellent! |
make sure the pr number does not include #... (Oreoxmt#11)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When you run
create translate PRon a PR page with a complicated URL (such ashttps://github.com/pingcap/docs-cn/pull/13637/files#diff-bd6f4007c98142e46e6906361bc0cabc0f45a5be07136472602de9a84156c393R24-R28), the created translate PR will have all the trailing params in its description.For example:
Fix:
This fix removes anything that comes after the pr number so that the source PR URL is clean.